examples : update vad support in stream example #3160
Draft
+171
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbev
force-pushed
the
stream-example-vad-update
branch
from
950d7c5 to
b924706
Compare
danbev
force-pushed
the
stream-example-vad-update
branch
from
654f1b4 to
ce75a8e
Compare
This commit updates the stream example to use the new Voice Activity Detection (VAD) support instead of the simple_vad which it currently used.
danbev
force-pushed
the
stream-example-vad-update
branch
2 times, most recently
from
06395a6 to
c8f8b4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the stream example to use the VAD support in whisper instead of the
simple_vadthat it currently uses.After first trying to just use the current VAD support that is "built-in" when calling
whisper_fullit became difficult to update this example. As a suggestion I've exposed awhisper_vadfunction which allows the VAD processing to be called separately and then if there if speech is detected the vad_samples that are returned can be used to withwhisper_fullbut this time there is no need to processing VAD soparams.vadshould be set to false.The built-in VAD works well for sample files but does not seem to be optimal for streaming, at least that is my feeling after trying to update this example.